morrySnow commented on code in PR #53707:
URL: https://github.com/apache/doris/pull/53707#discussion_r2221623041
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/IndexDef.java:
##########
@@ -160,7 +161,7 @@ public String toSql(String tableName) {
sb.append(")");
}
if (comment != null) {
- sb.append(" COMMENT '" + comment + "'");
+ sb.append("COMMENT
\"").append(SqlUtils.escapeQuota(comment)).append("\"");
Review Comment:
why change this? single quotes is better than double quotes, because if we
set sql_mode to ANSI_QUOTES, string in double quotes will be pased as
identifier, not string literal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
