BiteTheDDDDt commented on code in PR #11985:
URL: https://github.com/apache/doris/pull/11985#discussion_r954743926
##########
be/src/olap/comparison_predicate.h:
##########
@@ -199,6 +201,101 @@ class ComparisonPredicateBase : public ColumnPredicate {
_evaluate_bit<true>(column, sel, size, flags);
}
+ bool evaluate_and(const std::pair<WrapperField*, WrapperField*>&
statistic) const override {
+ if (statistic.first == nullptr || statistic.second == nullptr) {
Review Comment:
Does we can move those check out of this function? looks like a lot of
duplicate code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
