BiteTheDDDDt commented on code in PR #53653:
URL: https://github.com/apache/doris/pull/53653#discussion_r2224151176
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1190,9 +1190,11 @@ public RowBatch getNext() throws Exception {
}
if (ConnectContext.get() != null &&
ConnectContext.get().getSessionVariable().dryRunQuery) {
- if (resultBatch.isEos()) {
- numReceivedRows +=
resultBatch.getQueryStatistics().getReturnedRows();
- }
+ // In BE: vmysql_result_writer.cpp:GetResultBatchCtx::on_close()
+ // statistics->set_returned_rows(returned_rows);
+ // In a multi-mysql_result_writer scenario, since each
mysql_result_writer will set this rows, in order
+ // to avoid missing rows when dry_run_query = true, they should
all be added up.
+ numReceivedRows +=
resultBatch.getQueryStatistics().getReturnedRows();
Review Comment:
If one backend returns multiple batches, does it will the repeated
calculation lead to result row number more than real?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
