morningman commented on code in PR #53399:
URL: https://github.com/apache/doris/pull/53399#discussion_r2227050146


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonUtil.java:
##########
@@ -371,4 +379,68 @@ public static <T> String encodeObjectToString(T t) {
         }
     }
 
+    public static Map<String, String> getPartitionInfoMap(Table table, 
BinaryRow partitionValues, String timeZone) {

Review Comment:
   1. I think this method is too heavy.
   2. the key of `partitionInfoMap` can be removed? because all splits have 
same partition key



##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java:
##########
@@ -384,6 +384,9 @@ private void getPartitionSplits(HivePartition partition, 
List<Split> splits) thr
                 HudiSplit hudiSplit = new HudiSplit(locationPath, 0, fileSize, 
fileSize,
                         new String[0], partition.getPartitionValues());
                 hudiSplit.setTableFormatType(TableFormatType.HUDI);
+                if (sessionVariable.isEnableRuntimeFilterPartitionPrune()) {
+                    
hudiSplit.setHudiPartitionValues(HudiUtils.getPartitionInfoMap(hmsTable, 
partition));

Review Comment:
   the `HudiUtils.getPartitionInfoMap(hmsTable, partition)` should only be 
called once for one partition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to