CalvinKirs commented on code in PR #53571:
URL: https://github.com/apache/doris/pull/53571#discussion_r2227207761
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalCatalog.java:
##########
@@ -51,7 +55,21 @@ public IcebergExternalCatalog(long catalogId, String name,
String comment) {
}
// Create catalog based on catalog type
- protected abstract void initCatalog();
+ protected void initCatalog() {
+ try {
+ AbstractIcebergProperties properties = (AbstractIcebergProperties)
MetastoreProperties
+ .create(getProperties());
+ properties.initialize(getName(), new
ArrayList<>(catalogProperty.getStoragePropertiesMap().values()));
Review Comment:
MS hasn’t been fully integrated yet, so we can’t initialize it through the
common entry point. Ideally, we’ll eventually be able to create and initialize
the catalog based on the MS parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
