gavinchou commented on code in PR #53801:
URL: https://github.com/apache/doris/pull/53801#discussion_r2228413548
##########
be/src/io/fs/file_writer.h:
##########
@@ -42,8 +42,9 @@ struct FileWriterOptions {
bool used_by_s3_committer = false;
bool write_file_cache = false;
bool is_cold_data = false;
- bool sync_file_data = true; // Whether flush data into storage
system
- uint64_t file_cache_expiration = 0; // Absolute time
+ bool sync_file_data = true; // Whether flush data into storage
system
+ uint64_t file_cache_expiration = 0; // Absolute time
Review Comment:
naming `file_cache_expired_at_s`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
