eldenmoon commented on code in PR #53394:
URL: https://github.com/apache/doris/pull/53394#discussion_r2229998582


##########
be/src/vec/json/json_parser.h:
##########
@@ -49,8 +49,9 @@ Field getValueAsField(const Element& element) {
         return Field::create_field<TYPE_BIGINT>(element.getInt64());
     }
     // doris only support signed integers at present
+    // use largeint to store unsigned int64
     if (element.isUInt64()) {
-        return Field::create_field<TYPE_BIGINT>(element.getInt64());

Review Comment:
   can we handle TYPE_BOOLEAN in Field so that we can get the accurate boolean 
type



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to