dataroaring commented on code in PR #53540:
URL: https://github.com/apache/doris/pull/53540#discussion_r2232770247
##########
be/src/cloud/cloud_tablet.cpp:
##########
@@ -127,6 +129,48 @@ Status CloudTablet::capture_rs_readers(const Version&
spec_version,
return capture_rs_readers_unlocked(version_path, rs_splits);
}
+Status CloudTablet::capture_rs_readers_with_freshness_tolerance(
+ const Version& spec_version, std::vector<RowSetSplits>* rs_splits,
+ bool skip_missing_version, int64_t query_freshness_tolerance_ms) {
+ Versions version_path;
+ std::shared_lock rlock(_meta_lock);
+ // find a versin path where every edge(rowset) has been warmuped
+ auto validator = [&](int64_t start_version, int64_t end_version) -> bool {
+ if (start_version < end_version) {
+ return false;
+ }
Review Comment:
only allows start == end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
