yiguolei commented on code in PR #51623:
URL: https://github.com/apache/doris/pull/51623#discussion_r2232827110
##########
be/src/olap/rowset/segment_v2/column_writer.cpp:
##########
@@ -291,6 +292,20 @@ Status ColumnWriter::create_agg_state_writer(const
ColumnWriterOptions& opts,
return Status::OK();
}
+Status ColumnWriter::create_variant_writer(const ColumnWriterOptions& opts,
+ const TabletColumn* column,
io::FileWriter* file_writer,
+ std::unique_ptr<ColumnWriter>*
writer) {
+ if (column->is_extracted_column()) {
+ VLOG_DEBUG << "gen subwriter for " <<
column->path_info_ptr()->get_path();
+ *writer = std::unique_ptr<ColumnWriter>(new VariantSubcolumnWriter(
+ opts, column,
std::unique_ptr<Field>(FieldFactory::create(*column))));
+ return Status::OK();
+ }
+ *writer = std::unique_ptr<ColumnWriter>(new VariantColumnWriter(
Review Comment:
std::make_unique
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
