morningman commented on code in PR #53327:
URL: https://github.com/apache/doris/pull/53327#discussion_r2234597423
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonExternalCatalog.java:
##########
@@ -171,20 +171,20 @@ public List<Partition> getPaimonPartitions(NameMapping
nameMapping) {
}
}
- public org.apache.paimon.table.Table getPaimonSystemTable(NameMapping
nameMapping, String queryType) {
- return getPaimonSystemTable(nameMapping, null, queryType);
+ public org.apache.paimon.table.Table getPaimonTable(NameMapping
nameMapping, String queryType) {
Review Comment:
Unify these 2 methods with `public org.apache.paimon.table.Table
getPaimonTable(NameMapping nameMapping)`
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonExternalCatalog.java:
##########
@@ -171,20 +171,20 @@ public List<Partition> getPaimonPartitions(NameMapping
nameMapping) {
}
}
- public org.apache.paimon.table.Table getPaimonSystemTable(NameMapping
nameMapping, String queryType) {
- return getPaimonSystemTable(nameMapping, null, queryType);
+ public org.apache.paimon.table.Table getPaimonTable(NameMapping
nameMapping, String queryType) {
+ return getPaimonTable(nameMapping, null, queryType);
}
- public org.apache.paimon.table.Table getPaimonSystemTable(NameMapping
nameMapping, String branch,
+ public org.apache.paimon.table.Table getPaimonTable(NameMapping
nameMapping, String branch,
String queryType) {
makeSureInitialized();
try {
return hadoopAuthenticator.doAs(() -> catalog.getTable(new
Identifier(nameMapping.getRemoteDbName(),
nameMapping.getRemoteTblName(), branch, queryType)));
} catch (Exception e) {
- throw new RuntimeException("Failed to get Paimon system table:" +
getName() + "."
- + nameMapping.getRemoteDbName() + "." +
nameMapping.getRemoteTblName() + "$" + queryType
- + ", because " + e.getMessage(), e);
+ throw new RuntimeException("Failed to get Paimon table:" +
getName() + "."
Review Comment:
```suggestion
throw new RuntimeException("Failed to get Paimon table:" +
getName() + "."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
