TangSiyang2001 commented on code in PR #53952:
URL: https://github.com/apache/doris/pull/53952#discussion_r2234751668
##########
be/src/cloud/cloud_schema_change_job.cpp:
##########
@@ -556,7 +556,10 @@ Status
CloudSchemaChangeJob::_process_delete_bitmap(int64_t alter_version,
return Status::OK();
}
-void CloudSchemaChangeJob::clean_up_on_failed() {
+void CloudSchemaChangeJob::clean_up_on_failure() {
+ if (_new_tablet == nullptr) {
+ return;
Review Comment:
I think log here is pointless.
If get tablet failed, we could find details through log msg here:
```
W20250727 00:45:38.585376 5798 cloud_tablet_mgr.cpp:206] failed to tablet
1753547556250: [INVALID_ARGUMENT]failed to get tablet meta: empty instance_id
W20250727 00:45:38.585387 5797 cloud_tablet_mgr.cpp:206] failed to tablet
1753547556254: [INVALID_ARGUMENT]failed to get tablet meta: empty instance_id
W20250727 00:45:38.585376 5796 cloud_tablet_mgr.cpp:206] failed to tablet
1753547556252: [INVALID_ARGUMENT]failed to get tablet meta: empty instance_id
W20250727 00:45:38.599696 5797 status.h:426] meet error status:
[INTERNAL_ERROR]failed to get tablet 1753547556254
0# doris::CloudTabletMgr::get_tablet(long, bool, bool,
doris::SyncRowsetStats*, bool) at
/home/zcp/repo_center/doris_branch-3.0/doris/be/src/common/status.h:378
1#
doris::CloudSchemaChangeJob::process_alter_tablet(doris::TAlterTabletReqV2
const&) at
/home/zcp/repo_center/doris_branch-3.0/doris/be/src/util/expected.hpp:1986
2# doris::alter_cloud_tablet_callback(doris::CloudStorageEngine&,
doris::TAgentTaskRequest const&) at
/home/zcp/repo_center/doris_branch-3.0/doris/be/src/common/status.h:505
3# std::_Function_handler<void (),
doris::TaskWorkerPool::submit_task(doris::TAgentTaskRequest
const&)::$_0::operator()<doris::TAgentTaskRequest
const&>(doris::TAgentTaskRequest const&)
const::{lambda()#1}>::_M_invoke(std::_Any_data const&) at
/home/zcp/repo_center/doris_branch-3.0/doris/be/src/agent/task_worker_pool.cpp:546
4# doris::ThreadPool::dispatch_thread() at
/var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:1267
5# doris::Thread::supervise_thread(void*) at
/var/local/ldb-toolchain/bin/../usr/include/pthread.h:563
6# ?
7# ?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
