yiguolei commented on code in PR #54044:
URL: https://github.com/apache/doris/pull/54044#discussion_r2241388858
##########
be/src/vec/core/field.h:
##########
@@ -83,6 +83,27 @@ struct Map : public FieldVector {
using FieldVector::FieldVector;
};
+struct FieldWithDataType {
+ FieldWithDataType() = default;
+ explicit FieldWithDataType(Field&& f);
+ explicit FieldWithDataType(const Field& f);
+ explicit FieldWithDataType(Field&& f, int precision, int scale,
+ PrimitiveType base_scalar_type_id =
PrimitiveType::INVALID_TYPE,
+ uint8_t num_dimensions = 0);
+ FieldWithDataType(const FieldWithDataType&);
+ FieldWithDataType& operator=(const FieldWithDataType&);
+ FieldWithDataType& operator=(FieldWithDataType&&) = default;
+ FieldWithDataType(FieldWithDataType&&) = default;
+ ~FieldWithDataType() = default;
+
+ std::unique_ptr<Field> field;
Review Comment:
这里是不是如果不是unique ptr，我们就没必要定义这词儿operator=还有拷贝构造函数啥了？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
