stalary commented on code in PR #12148:
URL: https://github.com/apache/doris/pull/12148#discussion_r958151001
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java:
##########
@@ -202,15 +202,6 @@ public void analyze(boolean isOlap) throws
AnalysisException {
}
FeNameFormat.checkColumnName(name);
- // When string type length is not assigned, it need to be assigned to
1.
- if (typeDef.getType().isScalarType()) {
Review Comment:
I think varchar can keep the old logic, only modify String logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]