luozenglin commented on code in PR #12205:
URL: https://github.com/apache/doris/pull/12205#discussion_r959197263
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java:
##########
@@ -534,6 +539,12 @@ public TMasterOpResult proxyExecute(TMasterOpRequest
request) {
}
}
+ Map<String, String> traceCarrier = new HashMap<>();
+ if (request.isSetTraceCarrier()) {
+ traceCarrier = request.getTraceCarrier();
+ }
+ ctx.initTracer("master trace");
Review Comment:
I think `initTracer` is only needed if the `traceCarrier` carries a valid
span, otherwise a new trace may be generated here.
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -399,7 +413,17 @@ public void execute(TUniqueId queryId) throws Exception {
+ Env.getCurrentEnv().getSelfNode().first + ")
and failed to execute"
+ " because Master FE is not ready. You may
need to check FE's status");
}
- forwardToMaster();
+ Span forwardToMasterSpan =
Review Comment:
I think after adding span in MasterOpExecutor.execute, there is no need to
add `forwardToMasterSpan` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
