yiguolei commented on code in PR #54181:
URL: https://github.com/apache/doris/pull/54181#discussion_r2247294828
##########
be/src/olap/rowset/segment_v2/segment.h:
##########
@@ -220,6 +203,8 @@ class Segment : public
std::enable_shared_from_this<Segment>, public MetadataAdd
const TabletSchemaSPtr& tablet_schema() { return _tablet_schema; }
+ Result<ColumnReader*> get_column_reader(int32_t col_unique_id);
Review Comment:
改成 Status get_column_reader(int32_t col_unique_id, ColumnReader*); 这种接口样子吧，
保持跟同一个类中其他函数的接口风格一致。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
