zhiqiang-hhhh commented on code in PR #54223:
URL: https://github.com/apache/doris/pull/54223#discussion_r2247838792
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PushDownVirtualColumnsIntoOlapScan.java:
##########
@@ -107,6 +110,42 @@ public class PushDownVirtualColumnsIntoOlapScan implements
RewriteRuleFactory {
// Logger for debugging
private static final Logger logger =
LogManager.getLogger(PushDownVirtualColumnsIntoOlapScan.class);
+ // Supported primitive types by TabletColumn::get_field_length_by_type
+ // Based on the C++ implementation, these are the types that have defined
field lengths
+ private static final ImmutableSet<TPrimitiveType>
SUPPORTED_VIRTUAL_COLUMN_TYPES = ImmutableSet.of(
Review Comment:
> use nereids' type, do not use TPrimitiveType
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
