yujun777 commented on code in PR #54226:
URL: https://github.com/apache/doris/pull/54226#discussion_r2248967116
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java:
##########
@@ -858,7 +858,7 @@ public boolean isScaleInDrop() {
public boolean isAlive() {
return getState() != ReplicaState.CLONE
&& getState() != ReplicaState.DECOMMISSION
- && !isBad();
+ && !isBad() && !isUserDrop();
Review Comment:
isUserDrop means the replica going to be relocate, just like decommission a
be will relocate all its replicas.
notice when decommission a be, all its normal replicas are still alive,
for the same logic, when set a replica drop, if this replica state is still
normal, it must be alive.
cannot change a userDrop replica with normal state to non-alive, for
example, for replication_num = 1, when we set the only one replica as
userDrop, if we think this replica is non-alive, then the tablet will have 0
alive replica, and this tablet's status will be unrecoverable, and the
tabletScheduler wouldn't sched it since it's unrecoverable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
