amorynan commented on code in PR #54027: URL: https://github.com/apache/doris/pull/54027#discussion_r2250317012
########## be/src/vec/data_types/serde/complex_type_deserialize_util.h: ########## @@ -0,0 +1,106 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/common/string_ref.h" +#include "vec/data_types/serde/data_type_serde.h" + +namespace doris::vectorized { + +struct ComplexTypeDeserializeUtil { + // SplitResult is used to store the result of splitting a string by a delimiter. + // It contains the element as a StringRef and the delimiter used for splitting. + // For example, if the input string is "a,b,c" and the delimiter is ',', + // the SplitResult will contain three elements: {"a", ','}, {"b", ','}, {"c", }. + // If the input string is "a:b,c:d" and the delimiter is ';' or ',' + // the SplitResult will contain two elements: {"a", ':'}, {"b", ','}, {"c", ':'}, {"d", }. + struct SplitResult { + StringRef element; + char delimiter = 0; + }; + + template <typename Func> + static std::vector<SplitResult> split_by_delimiter(StringRef& str, Func func) { + char quote_char = 0; + int last_pos = 0; + int nested_level = 0; + bool has_quote = false; + char delimiter = 0; + std::vector<SplitResult> elements; + for (int pos = 0; pos < str.size; ++pos) { + char c = str.data[pos]; + if (c == '"' || c == '\'') { + if (!has_quote) { + quote_char = c; + has_quote = !has_quote; + } else if (has_quote && quote_char == c) { + quote_char = 0; + has_quote = !has_quote; + } + } else if (!has_quote && (c == '[' || c == '{')) { + ++nested_level; + } else if (!has_quote && (c == ']' || c == '}')) { + --nested_level; + } else if (!has_quote && nested_level == 0 && func(c)) { + delimiter = c; + if (last_pos != pos) { + elements.push_back({StringRef(str.data + last_pos, pos - last_pos), delimiter}); + } else { + /// TODO: It's best that our StringRef is a nullptr data here. + elements.push_back({StringRef(str.data + last_pos, 0), delimiter}); + } + last_pos = pos + 1; + } + } + + elements.push_back({StringRef(str.data + last_pos, str.size - last_pos), delimiter}); + + for (auto& e : elements) { + e.element = e.element.trim_whitespace(); + } + return elements; + } + + static bool is_null_string(const StringRef& str) { + if (str.size == 4) { + // null + return str.data[0] == 'n' && str.data[1] == 'u' && str.data[2] == 'l' && Review Comment: 这个会有 behavior change ，以前这个判断是放在 null serde 里面的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
