morrySnow commented on code in PR #53980:
URL: https://github.com/apache/doris/pull/53980#discussion_r2250532028
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Score.java:
##########
Review Comment:
update
`org.apache.doris.nereids.rules.expression.rules.FoldConstantRuleOnBE` to
forbid fold `score` function
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalOlapScan.java:
##########
@@ -67,19 +68,23 @@ public class PhysicalOlapScan extends
PhysicalCatalogRelation implements OlapSca
// use for virtual slot
private final List<NamedExpression> virtualColumns;
+ private final List<OrderKey> scoreOrderKeys;
+ private final Optional<Long> scoreLimit;
Review Comment:
update equals and hashCode function
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapScan.java:
##########
@@ -143,6 +143,9 @@ public class LogicalOlapScan extends LogicalCatalogRelation
implements OlapScan
private final Map<String, Set<List<String>>> colToSubPathsMap;
private final Map<Slot, Map<List<String>, SlotReference>> subPathToSlotMap;
+ private final List<OrderKey> scoreOrderKeys;
+ private final Optional<Long> scoreLimit;
Review Comment:
update hashCode and equals function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
