This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-3.1 by this push:
     new a7ac92b7c97 branch-3.1: [Bug](agg) fix agg with topn limit coredump 
with ctor same key twice #54137 (#54270)
a7ac92b7c97 is described below

commit a7ac92b7c97041673603e6ca60cd77b5ea25c507
Author: zhangstar333 <[email protected]>
AuthorDate: Mon Aug 4 17:51:30 2025 +0800

    branch-3.1: [Bug](agg) fix agg with topn limit coredump with ctor same key 
twice #54137 (#54270)
    
    picked from #54137
---
 be/src/pipeline/exec/aggregation_sink_operator.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/pipeline/exec/aggregation_sink_operator.cpp 
b/be/src/pipeline/exec/aggregation_sink_operator.cpp
index 39dfb4e7f3c..63d43e07511 100644
--- a/be/src/pipeline/exec/aggregation_sink_operator.cpp
+++ b/be/src/pipeline/exec/aggregation_sink_operator.cpp
@@ -601,6 +601,7 @@ bool 
AggSinkLocalState::_emplace_into_hash_table_limit(vectorized::AggregateData
                                 try {
                                     
HashMethodType::try_presis_key_and_origin(key, origin,
                                                                               
*_agg_arena_pool);
+                                    _shared_state->refresh_top_limit(i, 
key_columns);
                                     auto mapped =
                                             
_shared_state->aggregate_data_container->append_data(
                                                     origin);
@@ -609,7 +610,6 @@ bool 
AggSinkLocalState::_emplace_into_hash_table_limit(vectorized::AggregateData
                                         throw Exception(st.code(), 
st.to_string());
                                     }
                                     ctor(key, mapped);
-                                    _shared_state->refresh_top_limit(i, 
key_columns);
                                 } catch (...) {
                                     // Exception-safety - if it can not 
allocate memory or create status,
                                     // the destructors will not be called.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to