This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 69577c9bddf [fix](function) Fix functionbuilder check (#54255)
69577c9bddf is described below
commit 69577c9bddf048315b1a1d943c9923b0df4677bb
Author: dwdwqfwe <[email protected]>
AuthorDate: Tue Aug 5 16:30:48 2025 +0800
[fix](function) Fix functionbuilder check (#54255)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
be/src/vec/functions/function.cpp | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/be/src/vec/functions/function.cpp
b/be/src/vec/functions/function.cpp
index 465c28d1076..2fc81f6366e 100644
--- a/be/src/vec/functions/function.cpp
+++ b/be/src/vec/functions/function.cpp
@@ -24,6 +24,7 @@
#include <memory>
#include <numeric>
+#include "common/status.h"
#include "vec/aggregate_functions/aggregate_function.h"
#include "vec/columns/column.h"
#include "vec/columns/column_const.h"
@@ -257,9 +258,15 @@ void FunctionBuilderImpl::check_number_of_arguments(size_t
number_of_arguments)
size_t expected_number_of_arguments = get_number_of_arguments();
- CHECK_EQ(number_of_arguments, expected_number_of_arguments) << fmt::format(
+ DCHECK_EQ(number_of_arguments, expected_number_of_arguments) <<
fmt::format(
"Number of arguments for function {} doesn't match: passed {} ,
should be {}",
get_name(), number_of_arguments, expected_number_of_arguments);
+ if (number_of_arguments != expected_number_of_arguments) {
+ throw Exception(
+ ErrorCode::INVALID_ARGUMENT,
+ "Number of arguments for function {} doesn't match: passed {}
, should be {}",
+ get_name(), number_of_arguments, expected_number_of_arguments);
+ }
}
DataTypePtr FunctionBuilderImpl::get_return_type(const ColumnsWithTypeAndName&
arguments) const {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
