csun5285 commented on code in PR #54328: URL: https://github.com/apache/doris/pull/54328#discussion_r2253968222
########## be/src/vec/common/schema_util.h: ########## @@ -179,12 +179,11 @@ bool inherit_index(const std::vector<const TabletIndex*>& parent_indexes, // Status check_path_stats(const std::vector<RowsetSharedPtr>& intputs, RowsetSharedPtr output, // BaseTabletSPtr tablet); // -// // Calculate statistics about variant data paths from the encoded sparse column Review Comment: remove unused code ########## be/src/vec/common/schema_util.cpp: ########## @@ -1031,48 +1031,48 @@ Status aggregate_variant_extended_info( // return Status::OK(); // } // -// // Calculate statistics about variant data paths from the encoded sparse column Review Comment: remove unused code ########## be/src/olap/rowset/segment_v2/segment_writer.cpp: ########## @@ -50,7 +50,7 @@ #include "olap/rowset/segment_v2/inverted_index_writer.h" #include "olap/rowset/segment_v2/page_io.h" #include "olap/rowset/segment_v2/page_pointer.h" -// #include "olap/rowset/segment_v2/variant/variant_stats_calculator.h" Review Comment: remove unused code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
