Mryange commented on code in PR #54357:
URL: https://github.com/apache/doris/pull/54357#discussion_r2255712449
##########
be/src/vec/data_types/serde/data_type_date_or_datetime_serde.cpp:
##########
@@ -384,7 +384,11 @@ Status DataTypeDateSerDe<T>::from_string_strict_mode_batch(
CastToDateOrDatetime::from_string_strict_mode<true, IsDatetime>(str,
res, options.timezone,
params);
// only after we called something with `IS_STRICT = true`,
params.status will be set
- RETURN_IF_ERROR(params.status);
+ if (!params.status.ok()) [[unlikely]] {
Review Comment:
我们现在有一个from_string的单行处理的函数，相关的修改可能也要给那里加上。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
