morrySnow commented on code in PR #54391:
URL: https://github.com/apache/doris/pull/54391#discussion_r2256284479
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/IPv6Literal.java:
##########
@@ -35,6 +35,9 @@ public class IPv6Literal extends Literal implements
ComparableLiteral {
Pattern.compile("^([0-9a-fA-F]{1,4}:){7}[0-9a-fA-F]{1,4}$");
private static final Pattern IPV6_COMPRESS_REGEX =
Pattern.compile("^(([0-9A-Fa-f]{1,4}(:[0-9A-Fa-f]{1,4})*)?)::((([0-9A-Fa-f]{1,4}:)*[0-9A-Fa-f]{1,4})?)$");
+ private static final String IPV4_PART =
"(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)";
+ private static final Pattern IPV6_MAPPED_REGEX =
Review Comment:
it is better to add a fe ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
