gavinchou commented on code in PR #54284:
URL: https://github.com/apache/doris/pull/54284#discussion_r2256943501
##########
be/src/cloud/cloud_internal_service.cpp:
##########
@@ -149,13 +151,26 @@ bvar::Adder<uint64_t>
g_file_cache_warm_up_rowset_request_to_handle_slow_count(
"file_cache_warm_up_rowset_request_to_handle_slow_count");
bvar::Adder<uint64_t> g_file_cache_warm_up_rowset_handle_to_finish_slow_count(
"file_cache_warm_up_rowset_handle_to_finish_slow_count");
+bvar::Adder<uint64_t> g_file_cache_warm_up_rowset_wait_for_compaction_num(
+ "file_cache_warm_up_rowset_wait_for_compaction_num");
+bvar::Adder<uint64_t>
g_file_cache_warm_up_rowset_wait_for_compaction_timeout_num(
+ "file_cache_warm_up_rowset_wait_for_compaction_timeout_num");
void CloudInternalServiceImpl::warm_up_rowset(google::protobuf::RpcController*
controller
[[maybe_unused]],
const PWarmUpRowsetRequest*
request,
PWarmUpRowsetResponse* response,
google::protobuf::Closure* done)
{
brpc::ClosureGuard closure_guard(done);
+ std::shared_ptr<bthread::CountdownEvent> wait = nullptr;
+ timespec due_time;
+ if (request->has_sync_wait_timeout_ms() && request->sync_wait_timeout_ms()
> 0) {
Review Comment:
consider log every time that request with a wait timeout
compaction is much less than load, it is not verbose to log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
