dataroaring commented on code in PR #53540:
URL: https://github.com/apache/doris/pull/53540#discussion_r2259229890


##########
be/src/olap/version_graph.h:
##########
@@ -168,6 +184,21 @@ class TimestampedVersionTracker {
     Status capture_consistent_versions(const Version& spec_version,
                                        std::vector<Version>* version_path) 
const;
 
+    // Given a start, this method can find a version path which satisfy the 
following conditions:
+    // 1. all edges satisfy the conditions specified by `validator` in the 
graph.
+    // 2. the destination version is as far as possible.
+    // 3. the path is the shortest path.
+    // The version paths are added to version_path as return info.
+    // If this version not in main version, version_path can be included 
expired rowset.
+    // NOTE: this method may return edges which is in stale path
+    Status capture_consistent_versions_with_validator(
+            int64_t start, std::vector<Version>& version_path,
+            const std::function<bool(int64_t, int64_t)>& validator) const;
+
+    Status capture_newest_consistent_versions_with_validator(

Review Comment:
   What's the difference compared to capture_consistent_versions_with_validator?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to