morningman commented on code in PR #54300:
URL: https://github.com/apache/doris/pull/54300#discussion_r2264507192
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/metastore/AliyunDLFBaseProperties.java:
##########
@@ -61,28 +65,40 @@ public class AliyunDLFBaseProperties {
description = "Enable public access to Aliyun DLF.")
protected String dlfAccessPublic = "false";
- @ConnectorProperty(names = {DataLakeConfig.CATALOG_PROXY_MODE},
+ @ConnectorProperty(names = {DataLakeConfig.CATALOG_PROXY_MODE,
"dlf.proxy.mode"},
required = false,
description = "The proxy mode of the Aliyun DLF. Default is
DLF_ONLY.")
protected String dlfProxyMode = "DLF_ONLY";
public static AliyunDLFBaseProperties of(Map<String, String> properties) {
AliyunDLFBaseProperties propertiesObj = new AliyunDLFBaseProperties();
ConnectorPropertiesUtils.bindConnectorProperties(propertiesObj,
properties);
+ propertiesObj.checkAndInit();
return propertiesObj;
}
-
private ParamRules buildRules() {
return new ParamRules()
.require(dlfAccessKey, "dlf.access_key is required")
- .require(dlfSecretKey, "dlf.secret_key is required")
- .require(dlfEndpoint, "dlf.endpoint is required");
+ .require(dlfSecretKey, "dlf.secret_key is required");
}
public void checkAndInit() {
Review Comment:
```suggestion
private void checkAndInit() {
```
##########
fe/fe-core/src/main/java/org/apache/doris/planner/HiveTableSink.java:
##########
@@ -125,23 +124,17 @@ public void bindDataSink(Optional<InsertCommandContext>
insertCtx)
setSerDeProperties(tSink);
THiveLocationParams locationParams = new THiveLocationParams();
- LocationPath locationPath = null;
- try {
- locationPath = LocationPath.of(sd.getLocation(),
targetTable.getStoragePropertiesMap(), false);
- } catch (UserException e) {
- throw new RuntimeException(e);
- }
- String location = locationPath.getPath().toString();
- String storageLocation = locationPath.toStorageLocation().toString();
+ LocationPath locationPath = LocationPath.of(sd.getLocation(),
targetTable.getStoragePropertiesMap());
+ String location = sd.getLocation();
TFileType fileType = locationPath.getTFileTypeForBE();
if (fileType == TFileType.FILE_S3) {
- locationParams.setWritePath(storageLocation);
- locationParams.setOriginalWritePath(location);
- locationParams.setTargetPath(location);
+ locationParams.setWritePath(locationPath.getNormalizedLocation());
Review Comment:
I think the write path and OriginalWritePath are different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
