zclllyybb commented on code in PR #54515:
URL: https://github.com/apache/doris/pull/54515#discussion_r2264555724
##########
be/src/vec/functions/function_nullables.cpp:
##########
@@ -86,20 +86,16 @@ class FunctionNonNullable : public IFunction {
uint32_t result, size_t input_rows_count) const
override {
auto& data = block.get_by_position(arguments[0]);
if (const auto* col_null =
check_and_get_column<ColumnNullable>(data.column.get());
- col_null == nullptr) // raise error if input is not nullable.
- {
- return Status::InvalidArgument(
- "Try to use originally non-nullable column {} in
nullable's non-nullable "
- "convertion.",
- data.column->get_name());
- } else { // column is ColumnNullable
+ col_null != nullptr) { // raise error if input is not nullable.
Review Comment:
modify the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
