HappenLee commented on code in PR #54539:
URL: https://github.com/apache/doris/pull/54539#discussion_r2265590501
##########
be/src/olap/hll.h:
##########
@@ -287,6 +291,19 @@ class HyperLogLog {
src += 32;
dst += 32;
}
+#elif defined(__ARM_FEATURE_SVE)
+ uint64_t byte_len = svcntb();
+ int loop = HLL_REGISTERS_COUNT / byte_len;
+ uint8_t* dst = _registers;
+ const uint8_t* src = other_registers;
+ svbool_t pg = svptrue_b8();
+ for (int i = 0; i < loop; i++) {
+ svuint8_t xa = svld1(pg, dst);
+ svuint8_t xb = svld1(pg, src);
+ svst1(pg, dst, svmax_u8_x(pg, xa, xb));
+ src += byte_len;
+ dst += byte_len;
+ }
#else
Review Comment:
maybe we also need a neon impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
