zhiqiang-hhhh commented on code in PR #54276:
URL: https://github.com/apache/doris/pull/54276#discussion_r2269079991


##########
be/src/vector/faiss_vector_index.cpp:
##########
@@ -0,0 +1,396 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   > naming directory as vector_index is better or just move it into 
olap/rowset/segment_v2
   
   rename to vector_index is ok. It can not be moved to segment_v2 since some 
compile options of doris must can not be applied to vector_index.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to