xy720 commented on code in PR #54516:
URL: https://github.com/apache/doris/pull/54516#discussion_r2269556629
##########
gensrc/thrift/AgentService.thrift:
##########
@@ -428,6 +428,7 @@ struct TSnapshotRequest {
struct TReleaseSnapshotRequest {
1: required string snapshot_path
2: optional Types.TTabletId tablet_id
+ 3: optional bool is_job_finished
Review Comment:
这里改成is_job_completed，防止混淆，is_job_completed表示当前ReleaseSnapshotRequest是job完成时发送的还是取消时发送的
##########
be/src/cloud/cloud_snapshot_mgr.h:
##########
@@ -59,11 +59,11 @@ class CloudSnapshotMgr {
/**
* Releases a snapshot for the specified tablet.
* Behavior:
- * - Marks the snapshot as no longer in use.
+ * - Marks the snapshot to final state.
*
* @return status.
*/
- Status release_snapshot(int64_t tablet_id);
+ Status release_snapshot(int64_t tablet_id, bool is_completed);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
