morningman commented on code in PR #12389:
URL: https://github.com/apache/doris/pull/12389#discussion_r963615118
##########
be/src/service/internal_service.cpp:
##########
@@ -344,6 +346,8 @@ void
PInternalServiceImpl<T>::cancel_plan_fragment(google::protobuf::RpcControll
}
if (!st.ok()) {
LOG(WARNING) << "cancel plan fragment failed, errmsg=" <<
st.get_error_msg();
+ } else {
+ LOG(INFO) << "cancel fragment, fragment_instance_id=" << print_id(tid)
<< " successfully.";
Review Comment:
This is already a cancel log in `fragment_mgr()->cancel`
##########
be/src/service/internal_service.cpp:
##########
@@ -296,6 +296,8 @@ void
PInternalServiceImpl<T>::tablet_writer_cancel(google::protobuf::RpcControll
template <typename T>
Status PInternalServiceImpl<T>::_exec_plan_fragment(const std::string&
ser_request,
PFragmentRequestVersion
version, bool compact) {
+ // Could not parse fragment id from string here, just print a log to
indicate that BE received a request
+ LOG(INFO) << "received a plan fragment request";
Review Comment:
Remove this
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -248,31 +246,17 @@ Status FragmentExecState::execute() {
return Status::OK();
}
-Status FragmentExecState::cancel_before_execute() {
- // set status as 'abort', cuz cancel() won't effect the status arg of
DataSink::close().
-#ifndef BE_TEST
- SCOPED_ATTACH_TASK(executor()->runtime_state());
-#endif
- _executor.set_abort();
- _executor.cancel();
- if (_pipe != nullptr) {
- _pipe->cancel("Execution aborted before start");
Review Comment:
where to cancel this pipe now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
