gavinchou commented on code in PR #54653:
URL: https://github.com/apache/doris/pull/54653#discussion_r2272285740
##########
cloud/src/meta-service/meta_service_txn.cpp:
##########
@@ -2064,534 +2064,518 @@ void MetaServiceImpl::commit_txn_with_sub_txn(const
CommitTxnRequest* request,
std::stringstream ss;
int64_t txn_id = request->txn_id();
auto sub_txn_infos = request->sub_txn_infos();
- // Create a readonly txn for scan tmp rowset
- std::unique_ptr<Transaction> txn;
- TxnErrorCode err = txn_kv_->create_txn(&txn);
- if (err != TxnErrorCode::TXN_OK) {
- code = cast_as<ErrCategory::CREATE>(err);
- ss << "filed to create txn, txn_id=" << txn_id << " err=" << err;
- msg = ss.str();
- LOG(WARNING) << msg;
- return;
- }
- DORIS_CLOUD_DEFER {
- if (txn == nullptr) return;
+ do {
Review Comment:
break down into several functions maybe 7 parts will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
