Gabriel39 commented on code in PR #12407:
URL: https://github.com/apache/doris/pull/12407#discussion_r964670903
##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -67,6 +67,25 @@ void
ColumnNullable::update_hashes_with_value(std::vector<SipHash>& hashes,
}
}
+void ColumnNullable::update_crcs_with_value(std::vector<uint32_t>& hashes,
+ doris::PrimitiveType type,
+ const uint8_t* __restrict
null_data) const {
+ DCHECK(null_data == nullptr);
+ auto s = hashes.size();
+ DCHECK(s == size());
+ auto* __restrict real_null_data = assert_cast<const
ColumnUInt8&>(*null_map).get_data().data();
+ if (doris::simd::count_zero_num(reinterpret_cast<const
int8_t*>(real_null_data), s) == s) {
Review Comment:
May be we can unify these two function `this->hash_null()` and
`doris::simd::count_zero_num` ? I think it's better to use `!this->hash_null()`
here.
##########
be/src/runtime/primitive_type.h:
##########
@@ -33,43 +34,6 @@ class DateTimeValue;
class DecimalV2Value;
struct StringValue;
-enum PrimitiveType {
Review Comment:
Why delete this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
