xy720 commented on code in PR #12378:
URL: https://github.com/apache/doris/pull/12378#discussion_r964818244
##########
be/src/vec/columns/column_array.h:
##########
@@ -45,6 +45,18 @@ class ColumnArray final : public COWHelper<IColumn,
ColumnArray> {
ColumnArray(const ColumnArray&) = default;
+public:
+ // offsets of array is 64bit wise
+ using Offset64 = IColumn::Offset64;
+ using Offsets64 = IColumn::Offsets64;
+
+private:
+ // please use IColumn::Offset if we really need 32bit offset, otherwise
use ColumnArray::Offset64
+ using Offset [[deprecated("ColumnArray::Offset64 for Array,
IColumn::Offset for String")]] =
Review Comment:
Why should we still keep the ColumnArray::Offset, are there any other place
still using it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
