yiguolei commented on code in PR #54486:
URL: https://github.com/apache/doris/pull/54486#discussion_r2281420876
##########
be/src/vec/sink/writer/async_result_writer.cpp:
##########
@@ -99,34 +120,25 @@ Status AsyncResultWriter::start_writer(RuntimeState*
state, RuntimeProfile* oper
// Should set to false here, to
DCHECK(_finish_dependency);
_finish_dependency->block();
- // This is a async thread, should lock the task ctx, to make sure
runtimestate and operator_profile
- // not deconstructed before the thread exit.
- auto task_ctx = state->get_task_execution_context();
-
RETURN_IF_ERROR(ExecEnv::GetInstance()->fragment_mgr()->get_thread_pool()->submit_func(
- [this, state, operator_profile, task_ctx]() {
- SCOPED_ATTACH_TASK(state);
- auto task_lock = task_ctx.lock();
- if (task_lock == nullptr) {
- return;
- }
- this->process_block(state, operator_profile);
- task_lock.reset();
- }));
+ if (!_opened) {
Review Comment:
这个open 不能放在这里，得放到process block里。
因为他可能很重，导致pipeline 卡死
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
