This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new 3ecb67c7a09 Revert "branch-3.0: [fix](config) dynamic set FE 
masterOnly config wi… (#54929)
3ecb67c7a09 is described below

commit 3ecb67c7a0912e02f0400ed8b69a7f4e7c1ebe43
Author: Yongqiang YANG <[email protected]>
AuthorDate: Mon Aug 18 19:56:32 2025 +0800

    Revert "branch-3.0: [fix](config) dynamic set FE masterOnly config wi… 
(#54929)
    
    …ll lost …"
    
    This reverts commit b26cba1247c32ed97a7ad73a0afad97094880fb5.
    
    ### What problem does this PR solve?
    
    Issue Number: close #xxx
    
    Related PR: #xxx
    
    Problem Summary:
    
    ### Release note
    
    None
    
    ### Check List (For Author)
    
    - Test <!-- At least one of them must be included. -->
        - [ ] Regression test
        - [ ] Unit Test
        - [ ] Manual test (add detailed scripts or steps below)
        - [ ] No need to test or manual test. Explain why:
    - [ ] This is a refactor/code format and no logic has been changed.
            - [ ] Previous test can cover this change.
            - [ ] No code files have been changed.
            - [ ] Other reason <!-- Add your reason?  -->
    
    - Behavior changed:
        - [ ] No.
        - [ ] Yes. <!-- Explain the behavior change -->
    
    - Does this need documentation?
        - [ ] No.
    - [ ] Yes. <!-- Add document PR link here. eg:
    https://github.com/apache/doris-website/pull/1214 -->
    
    ### Check List (For Reviewer who merge this PR)
    
    - [ ] Confirm the release note
    - [ ] Confirm test cases
    - [ ] Confirm document
    - [ ] Add branch pick label <!-- Add branch pick label that this PR
    should merge into -->
---
 .../java/org/apache/doris/analysis/AdminSetConfigStmt.java   | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminSetConfigStmt.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminSetConfigStmt.java
index b197c6c2bca..458116924d7 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminSetConfigStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminSetConfigStmt.java
@@ -49,13 +49,11 @@ public class AdminSetConfigStmt extends DdlStmt implements 
NotFallbackInParser {
         }
         this.applyToAll = applyToAll;
 
-        if (!this.applyToAll) {
-            // we have to analyze configs here to determine whether to forward 
it to master
-            for (String key : this.configs.keySet()) {
-                if (ConfigBase.checkIsMasterOnly(key)) {
-                    redirectStatus = RedirectStatus.FORWARD_NO_SYNC;
-                    break;
-                }
+        // we have to analyze configs here to determine whether to forward it 
to master
+        for (String key : this.configs.keySet()) {
+            if (ConfigBase.checkIsMasterOnly(key)) {
+                redirectStatus = RedirectStatus.FORWARD_NO_SYNC;
+                this.applyToAll = false;
             }
         }
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to