dataroaring commented on code in PR #53908:
URL: https://github.com/apache/doris/pull/53908#discussion_r2282350457
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -3327,13 +3483,23 @@ void
MetaServiceImpl::update_delete_bitmap(google::protobuf::RpcController* cont
}
// 4. store all pending delete bitmap for this txn
- PendingDeleteBitmapPB delete_bitmap_keys;
+ std::vector<std::string> delete_bitmap_keys_v1;
+ std::vector<std::string> delete_bitmap_keys_v2;
for (size_t i = 0; i < request->rowset_ids_size(); ++i) {
+ std::string key;
MetaDeleteBitmapInfo key_info {instance_id, tablet_id,
request->rowset_ids(i),
request->versions(i),
request->segment_ids(i)};
- std::string key;
meta_delete_bitmap_key(key_info, &key);
- delete_bitmap_keys.add_delete_bitmap_keys(key);
+ delete_bitmap_keys_v1.emplace_back(key);
+ }
+ if (write_v2) {
+ for (size_t i = 0; i < request->v2_rowset_ids_size(); ++i) {
Review Comment:
v2_rowset_ids is similar to rowset_meta.rowset_id_v2(), so we'd better name
them in other ways.
e.g. v2_rowset_ids -> delta_rowset_ids indicates rowsets which introduce
changes, while others base_rowset_ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
