Gabriel39 commented on code in PR #54923:
URL: https://github.com/apache/doris/pull/54923#discussion_r2282415483
##########
be/src/vec/exec/scan/es_scanner.cpp:
##########
@@ -53,16 +53,12 @@ EsScanner::EsScanner(RuntimeState* state,
pipeline::ScanLocalStateBase* local_st
_es_scroll_parser(nullptr),
_docvalue_context(docvalue_context),
_doc_value_mode(doc_value_mode) {
- _is_init = false;
+ _has_prepared = false;
}
-Status EsScanner::prepare(RuntimeState* state, const VExprContextSPtrs&
conjuncts) {
- VLOG_CRITICAL << NEW_SCANNER_TYPE << "::prepare";
- RETURN_IF_ERROR(Scanner::prepare(_state, conjuncts));
-
- if (_is_init) {
- return Status::OK();
- }
+Status EsScanner::init(RuntimeState* state, const VExprContextSPtrs&
conjuncts) {
Review Comment:
CHECK `_has_prepared` is false to ensure `init` must be called before
`prepare`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
