morrySnow commented on code in PR #12482:
URL: https://github.com/apache/doris/pull/12482#discussion_r966182730
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/TypeCoercionUtils.java:
##########
@@ -189,6 +192,8 @@ public static Optional<DataType>
findTightestCommonType(DataType left, DataType
}
} else if (left instanceof CharacterType || right instanceof
CharacterType) {
tightestCommonType = StringType.INSTANCE;
+ } else if (left instanceof DecimalType && right instanceof
IntegralType) {
+ tightestCommonType = new DecimalType(9, 0);
Review Comment:
```suggestion
tightestCommonType = DecimalType.forType(right);
```
BTW, add left is IntegralType, right is DecimalType too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
