This is an automated email from the ASF dual-hosted git repository.
starocean999 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new aaa0574a61c [Chore](nereids) remove UninstallPluginStmt (#54820)
aaa0574a61c is described below
commit aaa0574a61cfb3da333da53780bea1cc614a7aa0
Author: yaoxiao <[email protected]>
AuthorDate: Tue Aug 19 14:14:59 2025 +0800
[Chore](nereids) remove UninstallPluginStmt (#54820)
---
.../apache/doris/analysis/UninstallPluginStmt.java | 75 ----------------------
.../main/java/org/apache/doris/catalog/Env.java | 9 ---
.../main/java/org/apache/doris/qe/DdlExecutor.java | 3 -
3 files changed, 87 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/UninstallPluginStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/UninstallPluginStmt.java
deleted file mode 100644
index dbc30ac7bcf..00000000000
---
a/fe/fe-core/src/main/java/org/apache/doris/analysis/UninstallPluginStmt.java
+++ /dev/null
@@ -1,75 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-package org.apache.doris.analysis;
-
-import org.apache.doris.catalog.Env;
-import org.apache.doris.common.AnalysisException;
-import org.apache.doris.common.Config;
-import org.apache.doris.common.ErrorCode;
-import org.apache.doris.common.ErrorReport;
-import org.apache.doris.common.UserException;
-import org.apache.doris.mysql.privilege.PrivPredicate;
-import org.apache.doris.qe.ConnectContext;
-
-public class UninstallPluginStmt extends DdlStmt implements
NotFallbackInParser {
-
- private String pluginName;
-
- public UninstallPluginStmt(String pluginName) {
- this.pluginName = pluginName;
- }
-
- public String getPluginName() {
- return pluginName;
- }
-
- @Override
- public void analyze() throws AnalysisException, UserException {
- super.analyze();
-
- if (!Config.plugin_enable) {
-
ErrorReport.reportAnalysisException(ErrorCode.ERR_OPERATION_DISABLED,
"UNINSTALL PLUGIN",
- "Please enable it by setting 'plugin_enable' = 'true'");
- }
-
- // check operation privilege
- if
(!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ADMIN)) {
-
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
"ADMIN");
- }
- }
-
- @Override
- public String toSql() {
- return "UNINSTALL PLUGIN " + pluginName;
- }
-
- @Override
- public String toString() {
- return toSql();
- }
-
- @Override
- public RedirectStatus getRedirectStatus() {
- return RedirectStatus.FORWARD_WITH_SYNC;
- }
-
- @Override
- public StmtType stmtType() {
- return StmtType.UNINSTALL;
- }
-}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
index d2192f2dfb0..642c865d596 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
@@ -41,7 +41,6 @@ import org.apache.doris.analysis.ReplacePartitionClause;
import org.apache.doris.analysis.RollupRenameClause;
import org.apache.doris.analysis.SlotRef;
import org.apache.doris.analysis.TableRenameClause;
-import org.apache.doris.analysis.UninstallPluginStmt;
import org.apache.doris.backup.BackupHandler;
import org.apache.doris.backup.RestoreJob;
import org.apache.doris.binlog.BinlogGcer;
@@ -6844,14 +6843,6 @@ public class Env {
}
}
- public void uninstallPlugin(UninstallPluginStmt stmt) throws IOException,
UserException {
- PluginInfo info = pluginMgr.uninstallPlugin(stmt.getPluginName());
- if (null != info) {
- editLog.logUninstallPlugin(info);
- }
- LOG.info("uninstall plugin = " + stmt.getPluginName());
- }
-
public void uninstallPlugin(UninstallPluginCommand cmd) throws
IOException, UserException {
PluginInfo info = pluginMgr.uninstallPlugin(cmd.getPluginName());
if (null != info) {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/DdlExecutor.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/DdlExecutor.java
index 5aaaa26907a..ec6f97085ba 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/DdlExecutor.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/DdlExecutor.java
@@ -28,7 +28,6 @@ import org.apache.doris.analysis.DropUserStmt;
import org.apache.doris.analysis.RefreshDbStmt;
import org.apache.doris.analysis.SetUserPropertyStmt;
import org.apache.doris.analysis.SyncStmt;
-import org.apache.doris.analysis.UninstallPluginStmt;
import org.apache.doris.catalog.EncryptKeyHelper;
import org.apache.doris.catalog.Env;
import org.apache.doris.common.Config;
@@ -65,8 +64,6 @@ public class DdlExecutor {
env.getAuth().updateUserProperty((SetUserPropertyStmt) ddlStmt);
} else if (ddlStmt instanceof SyncStmt) {
return;
- } else if (ddlStmt instanceof UninstallPluginStmt) {
- env.uninstallPlugin((UninstallPluginStmt) ddlStmt);
} else if (ddlStmt instanceof AdminSetPartitionVersionStmt) {
env.setPartitionVersion((AdminSetPartitionVersionStmt) ddlStmt);
} else if (ddlStmt instanceof RefreshDbStmt) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]