This is an automated email from the ASF dual-hosted git repository.
zclll pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new e3297b3fe20 [fix](asan) Fix ASAN error in
ScalarColumnReader::_read_nested_column under O0 compilation. (#54973)
e3297b3fe20 is described below
commit e3297b3fe202527b540fd40ce75adac22dd1fb99
Author: Mryange <[email protected]>
AuthorDate: Wed Aug 20 11:33:08 2025 +0800
[fix](asan) Fix ASAN error in ScalarColumnReader::_read_nested_column under
O0 compilation. (#54973)
### What problem does this PR solve?
There is a problem with the following code:
```cpp
size_t parsed_values = _chunk_reader->remaining_num_values() -
remaining_values;
_def_levels.resize(origin_size + parsed_values);
if (has_def_level) {
_chunk_reader->def_level_decoder().get_levels(&_def_levels[origin_size],
parsed_values);
}
```
When `parsed_values` equals 0, the size of `_def_levels` is
`origin_size`, but we attempt to access the element at index
`origin_size`.
With O0 compilation, ASAN will report an error in this case.
In fact, if `parsed_values` is 0, nothing will actually happen inside
`get_levels`.
---
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
b/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
index cf1b991667a..215f3ec2619 100644
--- a/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
+++ b/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
@@ -392,7 +392,10 @@ Status ScalarColumnReader::_read_nested_column(ColumnPtr&
doris_column, DataType
size_t parsed_values = _chunk_reader->remaining_num_values() -
remaining_values;
_def_levels.resize(origin_size + parsed_values);
if (has_def_level) {
-
_chunk_reader->def_level_decoder().get_levels(&_def_levels[origin_size],
parsed_values);
+ // if parsed_values is 0, we don't need to decode levels
+ if (parsed_values != 0) {
+
_chunk_reader->def_level_decoder().get_levels(&_def_levels[origin_size],
parsed_values);
+ }
} else {
std::fill(_def_levels.begin() + origin_size, _def_levels.end(), 0);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
