morningman commented on code in PR #55014:
URL: https://github.com/apache/doris/pull/55014#discussion_r2286923182
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogProperty.java:
##########
@@ -190,9 +190,23 @@ public Map<String, String> getHadoopProperties() {
if (hadoopProperties == null) {
synchronized (this) {
if (hadoopProperties == null) {
- Map<String, String> result = getProperties();
-
result.putAll(PropertyConverter.convertToHadoopFSProperties(getProperties()));
- this.hadoopProperties = result;
+ hadoopProperties = new HashMap<>();
+ Map<StorageProperties.Type, StorageProperties> storageMap
= getStoragePropertiesMap();
+
+ for (StorageProperties sp : storageMap.values()) {
+ Configuration configuration =
sp.getHadoopStorageConfig();
+ if (configuration != null) {
+ configuration.forEach(entry -> {
+ String key = entry.getKey();
+ String value = entry.getValue();
+ if (value != null) {
+ hadoopProperties.put(key, value);
+ }
+ });
+ } else {
+ LOG.warn("Hadoop storage config is null for
storage type: {}", sp.getType());
Review Comment:
Is this a warning log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
