hellozepp commented on PR #335:
URL: 
https://github.com/apache/doris-spark-connector/pull/335#issuecomment-3204842466

   > @hellozepp btw, is this not just a Spark3 problem, but a general problem?
   
   
   
https://github.com/apache/doris-spark-connector/blob/687d7ae0bd9a44d35c0096efe6f4b6cebaca31f7/spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/read/ReaderPartitionGenerator.java#L49
   
   
   It doesn't seem to be a general issue i think.
   - **Spark 2** : In the 'spark-doris-connector-base' module, 
ReaderPartitionGenerator.generatePartitions(DorisConfig, ...) directly reads 
'doris.filter.query' from the configuration. Additionally, DorisRelation passes 
the parameters through without modification.
   
   - **Spark 3** : It adopts DataSource V2 (following the path: 
AbstractDorisScan -> ReaderPartitionGenerator.generatePartitions(config, 
fields, filters, ...)). However, the legacy implementation fails to merge the 
'doris.filter.query' configuration item.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to