eldenmoon commented on code in PR #55036:
URL: https://github.com/apache/doris/pull/55036#discussion_r2289589397
##########
be/src/vec/columns/column_variant.h:
##########
@@ -584,6 +584,15 @@ class ColumnVariant final : public COWHelper<IColumn,
ColumnVariant> {
void clear_subcolumns_data();
+ size_t can_add_subcolumns_count() const {
Review Comment:
add comment
##########
be/src/olap/rowset/segment_v2/variant/hierarchical_data_iterator.cpp:
##########
@@ -357,6 +357,13 @@ Status HierarchicalDataIterator::_process_sparse_column(
container_variant.get_sparse_data_paths_and_values();
StringRef prefix_ref(_path.get_path());
std::string_view path_prefix(prefix_ref.data, prefix_ref.size);
+
+ // Collect subcolumns materialized from sparse data. We try to
densify frequent
+ // subpaths into real subcolumns under the capacity constraint of
the container.
+ std::unordered_map<std::string_view, ColumnVariant::Subcolumn>
+ subcolumns_from_sparse_column;
+ // How many more subcolumns we are allowed to add into the
container.
+ size_t count = container_variant.can_add_subcolumns_count();
Review Comment:
如果是查询v的话，这里count是不是等于0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
