zhiqiang-hhhh commented on code in PR #54276:
URL: https://github.com/apache/doris/pull/54276#discussion_r2289721878
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java:
##########
@@ -320,6 +320,7 @@ public enum RuleType {
PUSH_CONJUNCTS_INTO_ES_SCAN(RuleTypeClass.REWRITE),
PUSH_DOWN_VIRTUAL_COLUMNS_INTO_OLAP_SCAN(RuleTypeClass.REWRITE),
PUSH_DOWN_SCORE_TOPN_INTO_OLAP_SCAN(RuleTypeClass.REWRITE),
+ PUSH_DOWN_VECTOR_TOPN_INTO_OLAP_SCAN(RuleTypeClass.REWRITE),
Review Comment:
> could we merge the two rule into one?
maybe not. they have different condition, if we merge them together, we will
have many if else, will be not easy to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
