BiteTheDDDDt commented on issue #44730: URL: https://github.com/apache/doris/issues/44730#issuecomment-3212861770
> Hi, [@BiteTheDDDDt](https://github.com/BiteTheDDDDt) > > On **Doris 2.1.6 with enable_pipeline_exec=true and enable_pipeline_x_exec=false,** running TPC-DS 1GB query 14 triggers the same error: `sync filter size meet error.` > > PipelineX path: `HashJoinBuildSinkOperatorX::sink()` calls `send_filter_size()` at EOS. See code: > > [doris/be/src/pipeline/exec/hashjoin_build_sink.cpp](https://github.com/apache/doris/blob/fcc4635d0832740d88dd43bf68930e44e058b8a1/be/src/pipeline/exec/hashjoin_build_sink.cpp#L643-L647) > > Lines 643 to 647 in [fcc4635](/apache/doris/commit/fcc4635d0832740d88dd43bf68930e44e058b8a1) > if (!local_state._runtime_filters_disabled) { > RETURN_IF_ERROR(local_state._runtime_filter_slots->send_filter_size( > state, local_state._shared_state->build_block->rows(), > local_state._finish_dependency)); > } > > Non-PipelineX path: `HashJoinNode::sink()` does not call it at EOS. > > On the receiver side, whether `need_sync_filter_size()` is required is gated by the `enable_pipeline_exec `setting. However, the non-PipelineX pipeline engine doesn’t send the filter size, which leads to the mismatch and the error. See code: > > [doris/be/src/exprs/runtime_filter.cpp](https://github.com/apache/doris/blob/fcc4635d0832740d88dd43bf68930e44e058b8a1/be/src/exprs/runtime_filter.cpp#L1985-L1989) > > Lines 1985 to 1989 in [fcc4635](/apache/doris/commit/fcc4635d0832740d88dd43bf68930e44e058b8a1) > bool IRuntimeFilter::need_sync_filter_size() { > return (type() == RuntimeFilterType::IN_OR_BLOOM_FILTER || > type() == RuntimeFilterType::BLOOM_FILTER) && > _wrapper->get_build_bf_cardinality() && !_is_broadcast_join && _enable_pipeline_exec; > } > > Is there an LTS 2.x branch where this should be fixed? If so, I’m happy to submit a patch. Hi, the related issues have been fixed in the latest version 2.1. Please upgrade directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
