eldenmoon commented on code in PR #55127:
URL: https://github.com/apache/doris/pull/55127#discussion_r2291366073
##########
be/src/olap/rowset/segment_v2/variant/variant_column_reader.cpp:
##########
@@ -199,7 +199,7 @@ Status
VariantColumnReader::_new_iterator_with_flat_leaves(ColumnIteratorUPtr* i
const auto* node =
target_col.has_path_info() ?
_subcolumn_readers->find_leaf(relative_path) : nullptr;
if (!node) {
- if (relative_path.get_path() == SPARSE_COLUMN_PATH) {
+ if (relative_path.get_path() == SPARSE_COLUMN_PATH &&
_sparse_column_reader != nullptr) {
Review Comment:
这段pick到3.1，并说明是兜底case
##########
regression-test/suites/variant_p0/predefine/variant_count_zero_predefine.groovy:
##########
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
add case that mixed with different variant_max_subcolumns_count in the same
table
##########
regression-test/suites/variant_p0/predefine/variant_count_zero_predefine.groovy:
##########
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
example 0, 1, 5, 7, ...
##########
be/src/vec/common/schema_util.cpp:
##########
@@ -829,6 +837,12 @@ Status VariantCompactionUtil::check_path_stats(const
std::vector<RowsetSharedPtr
// in this case, input stats is accurate, so we check the stats size
and stats value
else {
for (const auto& [path, size] : stats) {
+ if (original_uid_to_path_stats.at(uid).find(path) ==
Review Comment:
为啥改这个
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
