yiguolei commented on code in PR #54582:
URL: https://github.com/apache/doris/pull/54582#discussion_r2302584790


##########
be/src/vec/functions/array/function_array_aggregation.cpp:
##########
@@ -237,6 +239,16 @@ struct ArrayAggregateImpl {
         const IColumn* data = array.get_data_ptr().get();
 
         const auto& offsets = array.get_offsets();
+        if constexpr (operation == AggregateOperation::MAX ||
+                      operation == AggregateOperation::MIN) {
+            // min/max can only be applied on ip type
+            if (execute_type<TYPE_IPV4>(res, type, data, offsets) ||
+                execute_type<TYPE_IPV6>(res, type, data, offsets)) {

Review Comment:
   ip 类型的min max 是什么含义?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to