HappenLee commented on code in PR #55389:
URL: https://github.com/apache/doris/pull/55389#discussion_r2306099635
##########
be/src/vec/functions/date_format_type.h:
##########
@@ -60,9 +60,13 @@ void put_two_digits(T m, char* buf, int& i) {
}
// UserDefinedImpl indicates that no specific optimization has been applied,
and the general logic is used for processing.
-struct UserDefinedImpl {};
+struct UserDefinedImpl {
+ // for UserDefinedImpl, we use insert_data interface rather than directly
write to buffer. so no need to preserve.
+ constexpr static size_t row_size = 0;
Review Comment:
reserve we still have a better performance. no need be zero, should have a
proper size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
